I am a high school student trying to become familiar with the opensource
process and linux kernel. This is my first submission to the mailing list.
I fixed the slicoss sub-system. The TODO file asks to remove volatile
variables - also, checkpatch.pl warnings included volatile variables.
I removed "volatile" from the variables /isr /and /linkstatus/ in the
header file, because they are not needed. The two variables are used in
the slicoss.c file, where /isr/ is used as function parameters, string
outputs, pointers, logic, and one assignment, while /linkstatus /is used
as pointers, logic, and one assignment. All but the assignments will not
change these variables, and the assignment does not warrant a volatile
qualifier.
To make sure the changes were correct, I ran the files with
checkpatch.pl again, test built it, and rebooted it.
Signed-off-by: Vikul Gupta <guptav@xxxxxxxxxxxxxxxxxx>
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
index 3a5aa88..f19f86a 100644
--- a/drivers/staging/slicoss/slic.h
+++ b/drivers/staging/slicoss/slic.h
@@ -357,8 +357,8 @@ struct base_driver {
};
struct slic_shmem {
- volatile u32 isr;
- volatile u32 linkstatus;
+ u32 isr;
+ u32 linkstatus;
volatile struct slic_stats inicstats;
};
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
