On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote:
> Variable "u32 c" always re-initialize in for loop.
> Initialized value of "u32 c" is not used in function
> and is redundant, hence removed.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Sunil Shahu <shshahu@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/rtl871x_security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
> index 21465c9..8627928 100644
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -125,7 +125,7 @@ static u8 crc32_reverseBit(u8 data)
> static void crc32_init(void)
> {
> sint i, j;
> - u32 c = 0x12340000;
> + u32 c;
> u8 *p = (u8 *)&c, *p1;
> u8 k;
>
> --
> 1.9.1
The patch is good, the value assigned to c is immediately overwritten.
Unfortunately the patch fails to apply in staging-testing and linux-next. Could
you please rebase?
Thanks,
Luis
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
