On Fri, 2015-06-26 at 17:11 +0200, Luis de Bethencourt wrote: > On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote: > > On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote: > > > Fix all checkpatch.pl warnings: > > > WARNING: unnecessary whitespace before a quoted newline > > > > Unassociated but: > > > > > diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > > [] > > > @@ -740,7 +740,7 @@ s32 Handle_set_IPAddress(void *drvHandler, u8 *pu8IPAddr, u8 idx) > > > if (pu8IPAddr[0] < 192) > > > pu8IPAddr[0] = 0; > > > > > > - PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d \n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]); > > > + PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8IPAddr[2], pu8IPAddr[3]); > > > > These printks with ip addresses could use vsprintf extension %pI4 > > > > PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %pI4\n", > > idx, pu8IPAddr); > > > > > > Hi Joe, Hello Luis. > I could send this as a 5th patch in the series if you'd like, and set you as > author. Sure, but if you're doing it, you are the author. You could use a "Suggested-by" tag, but I don't care. > - PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %d.%d.%d.%d\n", idx, pu8IPAddr[0], pu8IPAddr[1], pu8 IPAddr[2], pu8IPAddr[3]); > + PRINT_INFO(HOSTINF_DBG, "Indx = %d, Handling set IP = %pI4\n", idx, pu8IPAddr); There are 3 sites in host_interface that could be changed. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
