Re: [PATCH] staging: sm750fb: use tabs for indentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 22, 2015 at 11:30:30AM -0700, Juston Li wrote:
> On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter
> <dan.carpenter@xxxxxxxxxx> wrote:
> > On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
> >>  void sii164ClearInterrupt(void)
> >>  {
> >> -    unsigned char detectReg;
> >> +     unsigned char detectReg;
> >>
> >> -    /* Clear the MDI interrupt */
> >> -    detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
> >> -    i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR);
> >
> > The patch accidentally deletes this write.
> >
> >> +     /* Clear the MDI interrupt */
> >> +     detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
> >>  }
> >
> > regards,
> > dan carpenter
> 
> This was fixed and patch is now included in the patchset:
> [PATCH v2 00/19] staging: sm750fb: checkpatch.pl fixes

Have you sent this patchset to the list?  I don't see it in my inbox.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux