On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ > qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? 2:qos_param->aifs[aci]; > > - qos_param->cw_min[aci] = ac_params->ecw_min_max & 0x0F; > + qos_param->cw_min[aci] = > + cpu_to_le16(ac_params->ecw_min_max & 0x0F); > > - qos_param->cw_max[aci] = (ac_params->ecw_min_max & 0xF0) >> 4; > + qos_param->cw_max[aci] = > + cpu_to_le16((ac_params->ecw_min_max & 0xF0) >> 4); > > qos_param->flag[aci] = > (ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00; > - qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit); > + qos_param->tx_op_limit[aci] = ac_params->tx_op_limit; > } > return 0; This certainly needs a more thorough description of how you determined that the byte swaps that you add are in fact required. Did you test it on a big-endian machine? Arnd _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel