Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence

[Markus Böhme <markus.boehme@xxxxxxxxxxx>]

> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>   		return result;
>
>   	s = &dev->subdevices[2];
> -	result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> -				  dioP2ExpansionIO8Bit);
> -	if (result)
> -		return result;
> -
> -	return 0;
> +	return subdev_8255_init(dev, s, daqboard2000_8255_cb,
> +			dioP2ExpansionIO8Bit);
>   }

What do you think about horizontally aligning the parameters in the second line?
They were previously.

Regards,
Markus


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel