On Thu, Jun 18, 2015 at 02:00:18PM +0530, Sudip Mukherjee wrote: > On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote: > > --- a/drivers/staging/rtl8188eu/hal/odm.c > > +++ b/drivers/staging/rtl8188eu/hal/odm.c > > @@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct *pDM_Odm) > > } > > > > for (i = 0; i < sta_cnt; i++) { > > - if (PWDB_rssi[i] != (0)) { > > - if (pHalData->fw_ractrl) { > > - /* Report every sta's RSSI to FW */ > > - } else { > > - ODM_RA_SetRSSI_8188E( > > - &(pHalData->odmpriv), (PWDB_rssi[i]&0xFF), (u8)((PWDB_rssi[i]>>16) & 0xFF)); > > - } > > + if (PWDB_rssi[i] != 0) { > > + ODM_RA_SetRSSI_8188E(&pHalData->odmpriv, > > + PWDB_rssi[i] & 0xFF, > > + (PWDB_rssi[i] >> 16) & 0xFF); > and you are also removing an extra unneeded () and a typecast. These are minor related changes (on the same line). It could have been mentioned in the changelog but if not then it's not really worth worrying about because it's so small. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel