Re: [PATCH] staging: comedi: don't split Author string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/06/15 21:14, Luis de Bethencourt wrote:
fixes checkpatch.pl WARNING: quoted string split across lines

+MODULE_AUTHOR("David A. Schleef <ds@xxxxxxxxxxx>, "
+             "Frank Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>");

total: 0 errors, 1 warnings, 114 lines checked

Modules with multiple authors have a MODULE_AUTHOR line for each one.

Signed-off-by: Luis de Bethencourt <luis@xxxxxxxxxxxxxxxxx>
---
  drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
index 93fab68..9c02b17 100644
--- a/drivers/staging/comedi/drivers/das08_cs.c
+++ b/drivers/staging/comedi/drivers/das08_cs.c
@@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
  };
  module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);

-MODULE_AUTHOR("David A. Schleef <ds@xxxxxxxxxxx>, "
-	      "Frank Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>");
+MODULE_AUTHOR("David A. Schleef <ds@xxxxxxxxxxx>");
+MODULE_AUTHOR("Frank Mori Hess <fmhess@xxxxxxxxxxxxxxxxxxxxx>");
  MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
  MODULE_LICENSE("GPL");


Okay, it would be nice if the patch subject line mentioned the name of the module, but this is the only one in COMEDI with a split author line.

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux