On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > 'WARNING: please, no spaces at the start of a line' > > checkpatch doesn't catch comments indented by spaces but I fixed comments > adjacent to warnings as well so they would remain aligned. > > Signed-off-by: Juston Li <juston.h.li@xxxxxxxxx> > --- <snip> > diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c > index 7826376..23d6e19 100644 > --- a/drivers/staging/sm750fb/ddk750_hwi2c.c > +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c > @@ -9,71 +9,69 @@ > #define HWI2C_WAIT_TIMEOUT 0xF0000 > > > -int hwI2CInit( > - unsigned char busSpeedMode > -) > +int hwI2CInit(unsigned char busSpeedMode) but this is what you say in commit message. Please only do one type of change in a single patch. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel