On Thu, 2015-06-18 at 16:04 -0700, Greg KH wrote: > On Thu, Jun 18, 2015 at 06:49:51PM +0100, Bilel DRIRA wrote: > > This patch fixes the following sparse warnings: [] > > diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c [] > > @@ -245,10 +245,12 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr, [] > > - memset(s3data, 0, sizeof(s3data)); > > + for (s3data_count = 0; s3data_count < S3DATA_MAX; s3data_count++) > > + memset(&s3data[s3data_count], 0, sizeof(struct s3datarec)); > > You are doing the exact same thing here that the original code did, so > why change it? > > That sparse warning is just a hint, I don't see anything wrong here with > the original code, sorry. Greg's right. A possible improvement would be to malloc/free memory as necessary instead of using large static buffers. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
