On 18/06/15 18:54, H Hartley Sweeten wrote:
Many of the comedi drivers support multiple boards with different features. The differences are usually handled by some type of const array that describes the board. A pointer this data is stored in the comedi_device as the 'dev->board_ptr'. Most of the drivers use a local variable called 'board' to reference the dev->board_ptr when needed. There are a couple drivers that use some other name for the local variable. To make all the comedi drivers consistent, rename all the variables used to reference the dev->board_ptr to 'board'. Also, tidy up a couple odd 'probe' functions used to find the correct boardinfo. v2: address issues pointed out by Ian Abbott and Sudip Mukherjee. H Hartley Sweeten (23): staging: comedi: amplc_pc236_common: rename 'thisboard' variables staging: comedi: amplc_pci224: rename 'thisboard' variables staging: comedi: amplc_pci230: rename 'thisboard' variables staging: comedi: cb_pcidda: rename 'thisboard' variables staging: comedi: ni_670x: rename 'thisboard' variables staging: comedi: ni_at_a2150: cleanup a2150_probe() staging: comedi: ni_at_a2150: rename 'thisboard' variables staging: comedi: das08_isa: rename 'thisboard' variables staging: comedi: das08: rename 'thisboard' variables staging: comedi: das800: cleanup das800_probe() staging: comedi: das800: rename 'thisboard' variables staging: comedi: das1800: cleanup das1800_probe() staging: comedi: das1800: rename 'thisboard' variables staging: comedi: me4000: rename 'thisboard' variables staging: comedi: cb_pcidas: rename 'thisboard' variables staging: comedi: cb_pcidas64: rename 'thisboard' variables staging: comedi: adv_pci_dio: rename 'this_board' variables staging: comedi: dt3000: rename 'this_board' variables staging: comedi: vmk80xx: rename 'boardinfo' variables staging: comedi: vmk80xx: sanity check context used to get the boardinfo staging: comedi: ni_atmio: cleanup ni_getboardtype() staging: comedi: addi_apci_1516: rename 'this_board' variables staging: comedi: addi_apci_3120: rename 'this_board' variables drivers/staging/comedi/drivers/addi_apci_1516.c | 24 +-- drivers/staging/comedi/drivers/addi_apci_3120.c | 14 +- drivers/staging/comedi/drivers/adv_pci_dio.c | 48 ++--- .../staging/comedi/drivers/amplc_pc236_common.c | 12 +- drivers/staging/comedi/drivers/amplc_pci224.c | 42 ++-- drivers/staging/comedi/drivers/amplc_pci230.c | 44 ++--- drivers/staging/comedi/drivers/cb_pcidas.c | 64 +++--- drivers/staging/comedi/drivers/cb_pcidas64.c | 218 ++++++++++----------- drivers/staging/comedi/drivers/cb_pcidda.c | 16 +- drivers/staging/comedi/drivers/das08.c | 51 +++-- drivers/staging/comedi/drivers/das08_isa.c | 4 +- drivers/staging/comedi/drivers/das1800.c | 86 ++++---- drivers/staging/comedi/drivers/das800.c | 75 +++---- drivers/staging/comedi/drivers/dt3000.c | 22 +-- drivers/staging/comedi/drivers/me4000.c | 30 +-- drivers/staging/comedi/drivers/ni_670x.c | 12 +- drivers/staging/comedi/drivers/ni_at_a2150.c | 38 ++-- drivers/staging/comedi/drivers/ni_atmio.c | 27 ++- drivers/staging/comedi/drivers/vmk80xx.c | 33 ++-- 19 files changed, 432 insertions(+), 428 deletions(-)
Looks good. Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Web: http://www.mev.co.uk/ )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
