On Tue, Jun 16, 2015 at 02:04:21PM +0100, Ian Abbott wrote: > On 16/06/15 06:34, Gujulan Elango, Hari Prasath (H.) wrote: > >On Mon, Jun 15, 2015 at 03:42:07PM +0100, Ian Abbott wrote: > >>On 15/06/15 15:01, Gujulan Elango, Hari Prasath (H.) wrote: > >>>From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > >>> > >>>This patch renames the very generic variable name 'todo' to > >>>num_samples_to_read. > >>> > >>>Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > [snip] > >>I don't see anything particularly wrong with the old name, but the > >>new name is a bit long. Most of the comedi drivers seem to use the > >>name 'nsamples' for this. > > > >I will leave it to you to decide on this.Should I resend the patch with > >a shorter variable name as 'nsamples' or leave it undisturbed and drop > >this patch. > > I'm happy either way, but if you're going to repost it, please > improve the subject line as well to localize the patch better. > Maybe something like: > > staging: comedi: amplc_pci230: rename 'todo' variable > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- > -=( Web: http://www.mev.co.uk/ )=- Sorry that won't be a v2.It will be a new patch as subject line changes.Please discard this one. regards Hari Prasath _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
