[BUG ?] staging: rtl8723au: condition with no effect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



scanning for trivial bug-patters with coccinelle spatches returned:
./drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1395
	WARNING: condition with no effect (if branch == else)

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c - line numbers from 4.1-rc7
1395    if (bWithoutHWSM) {
1396            /* value16 |= (APDM_HOST | FSM_HSUS |/PFM_ALDN); */
1397            /*  2010/08/31 According to Filen description, we need to
1398                use HW to shut down 8051 automatically. */
1399            /*  Because suspend operation need the asistance of 8051
1400                to wait for 3ms. */
1401            value16 = APDM_HOST | AFSM_HSUS | PFM_ALDN;
1402    } else {
1403            value16 = APDM_HOST | AFSM_HSUS | PFM_ALDN;
1404    }
1405 
1406    rtl8723au_write16(padapter, REG_APS_FSMCO, value16);    /* 0x4802 */

Not clear what the intent is but this looks like a typo/bug in the assigment
of value16 as the condition here has no effect.

thx!
hofrat
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux