On Fri, Jun 12, 2015 at 03:26:26PM -0700, Greg KH wrote: > On Fri, Jun 12, 2015 at 10:06:16PM +0100, One Thousand Gnomes wrote: > > On Fri, 12 Jun 2015 13:43:27 -0700 > > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > On Fri, Jun 12, 2015 at 10:20:38PM +0200, julien.dehee@xxxxxxxxx wrote: > > > > From: Julien Dehee <julien.dehee@xxxxxxxxx> > > > > > > > > comedi/comedi_fops.c > > > > use ENODEV following open manual > > > > That should probably be ENXIO by a strict reading, but Linux has always > > used ENODEV 8) > > > > > > > > > > comedi/drivers.c > > > > use ENOTTY following ioctl manual > > > > > > > > drivers/serial2002.c > > > > use ENOTTY following ioctl manual > > > > > > What do you mean by "ioctl manual"? > > > > man 2 ioctl > > > > Unknown ioctls on a device should error with ENOTTY. It's one of > > those crazy pieces of Unix history. > > Note that the man 2 ioctl interface is not always what the kernel > exposes, but rather, what your libc exposes to other programs. So > setting these kernel values might not change what you get all the way > through, have you tested it? We also have the issue of the existing userspace comedi code, I don't know if it's handling the ioctl errors differently than ioctl(2) says, but that should be checked as well before I can take this patch. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
