Re: [PATCH 2/3] staging: unisys: convert pack pragma to __packed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 12, 2015 at 01:43:33PM -0400, Benjamin Romer wrote:
> From: David Kershner <david.kershner@xxxxxxxxxx>
> 
> It was noticed that iochannel.h was still using pragmas to
> pack the datastructures, should be using __packed instead.
> 
> Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx>
> Signed-off-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
> ---
>  drivers/staging/unisys/include/iochannel.h | 45 +++++++++++++-----------------
>  1 file changed, 20 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/unisys/include/iochannel.h b/drivers/staging/unisys/include/iochannel.h
> index db7b332..1517496 100644
> --- a/drivers/staging/unisys/include/iochannel.h
> +++ b/drivers/staging/unisys/include/iochannel.h
> @@ -1,4 +1,5 @@
>  /* Copyright (C) 2010 - 2013 UNISYS CORPORATION */
> +
>  /* All rights reserved. */
>  #ifndef __IOCHANNEL_H__
>  #define __IOCHANNEL_H__
> @@ -149,22 +150,18 @@ enum vdisk_mgmt_types {
>  
>  /* structs with pragma pack  */
>  
> -#pragma pack(push, 1)
>  struct phys_info {
>  	u64 pi_pfn;
>  	u16 pi_off;
>  	u16 pi_len;
> -};
> -#pragma pack(pop)
> +} __packed;
>  /* ///////////// BEGIN PRAGMA PACK PUSH 1 ///////////////////////// */
>  /* ///////////// ONLY STRUCT TYPE SHOULD BE BELOW */

You can delete this comment now, as it's not correct anymore.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux