On Thu, Jun 11, 2015 at 09:13:50AM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Thu, Jun 11, 2015 at 07:48:43AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > > > > This patch removes code that is unused for any functionality in the > > ioctl SIOCDEVPRIVATE + 1.But since it is mentioned in the TODO > > list that it needs to be replaced with generic API functions,the > > debug print alone is left as it is. > > > > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > > --- > > drivers/staging/wilc1000/linux_wlan.c | 53 ----------------------------------- > > 1 file changed, 53 deletions(-) > > I need an ack from one of the maintainers of this driver before I can > accept this patch, as you are removing functionality from it. > It should be fine. It just removes some printks. Also if "priv_cmd.total_len" is zero then the code will oops and it leaks memory every time it's called. I would just remove the whole case statement along with the debug code. So resend it and make the changelog something like: "This patch removes SIOCDEVPRIVATE + 1 ioctl. It currently is just a stub which does some useless printks and returns. In the original code, if the user passes priv_cmd.total_len == 0 then it will Oops. Also it leaks memory every time it's called. In the future, we will implement this functionality using generic API functions." If you send a patch description like that it's easier to review and apply. I will be offline for the next week. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
