On Thu, Jun 11, 2015 at 01:52:28PM +0900, Dean.lee wrote: > > > On 2015년 06월 11일 12:50, Greg KH wrote: > >On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: > >>This driver has odd message in print string. > >>So this patch removes the data type. > >> > >>Signed-off-by: Dean Lee <dean.lee@xxxxxxxxx> > >>--- > >> drivers/staging/wilc1000/host_interface.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >>diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c > >>index 1ecb373..9e055c4 100644 > >>--- a/drivers/staging/wilc1000/host_interface.c > >>+++ b/drivers/staging/wilc1000/host_interface.c > >>@@ -703,7 +703,7 @@ static WILC_Sint32 Handle_SetOperationMode(void *drvHandler, tstrHostIfSetOperat > >> strWID.s32ValueSize = sizeof(WILC_Uint32); > >> /*Sending Cfg*/ > >>- PRINT_INFO(HOSTINF_DBG, "(size_t)pstrWFIDrv= %p \n", pstrWFIDrv); > >>+ PRINT_INFO(HOSTINF_DBG, "pstrWFIDrv= %p \n", pstrWFIDrv); > >Why are you printing a kernel pointer to userspace always? That's not a > >good idea, why not just delete this line, how useful is it? > > > >thanks, > > > >greg k-h > we need this line for deep level debugging. > sometime we need check and compare pointer value. Really, even at this stage of development for the code? > but we have plan for rework print message. > delete unused & not required print message. Good, all of them need to be reworked. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
