On 2015년 06월 11일 09:40, Greg KH wrote:
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote:
-static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler)
+static int wilc_wlan_cfg_commit(int type, size_t drvHandler)
Shouldn't this just be a void *? And if so, why not the real function
pointer instead?
Also, lots of these seem to be just pointers, please use a pointer
instead of hiding it in a size_t as that's the most portable, and
correct, way to do it. No need to hide any function pointers here, this
isn't Windows :)
thanks,
greg k-h
To replace the integer to the pointer as your counsel, I need a lot of
discussion internally. But I will fix the type and the related things
like your thinking.
I know there is the build warning for 64-bit machine and this driver stays
in BROKEN status on linux-next.
I want to know if the reason is 64bit build warning.
Thanks for your help.
Regards
Johnny
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
