Re: [PATCHv2 1/2] staging: dgap: cleanup driver module exit and remove function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2015 at 10:11:37AM +0300, Dan Carpenter wrote:
> I mean, yes, it doesn't seem to make much sense to continue polling
> after all the hardware has been removed.  The problem is that we pass a
> pci_dev pointer to dgap_remove_one() and it ignores it and removes
> everything.
> 
> Otherwise, I would probably suggest that it start polling when the first
> hardware is probed and stop when all the hardware is removed.
> 
> Also this driver has active maintainers but somehow we have CC'd the
> ATMEL people who maintain a different staging driver...

That was a mistake on my part.I was sending patches to the wilc1000
driver and thats how atmel guys were CC'd by mistake.Thanks Dan for
pointing this out and thanks sudip for copying the correct maintainers.

I will take some time to go through the code/review comments and send
out another version.

Thanks & Regards,
Hari Prasath
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux