Re: [PATCH 1/4] staging: wilc1000: modify data type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote:
> This replace the argument of the function to the independent data type
> in system.
> 
> Signed-off-by: Johnny Kim <johnny.kim@xxxxxxxxx>

This changelog says what you are doing but not why.

What is the point of ->u32Address?  Now that it's not 32 bits, the name
makes no sense.  Why not just make it a pointer?

There was someone changing all the datatypes with sed.  In some ways,
those patches were easier to review because they were mindless and not
really expected to make sense.  After we just sed the code to make it
look more normal then we can think about 64 bit bugs (like this patch
and the next).

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux