Re: [PATCH 2/2] staging: dgap: delete obvious comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2015 at 01:01:20AM +0300, Dan Carpenter wrote:
> On Tue, Jun 09, 2015 at 05:27:00PM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> > 
> > Deleting obvious comments
> > 
> > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> > ---
> >  drivers/staging/dgap/dgap.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> > index 185e9e5..03153d8 100644
> > --- a/drivers/staging/dgap/dgap.c
> > +++ b/drivers/staging/dgap/dgap.c
> > @@ -7104,8 +7104,6 @@ static void dgap_stop(void)
> >  
> >  /*
> >   * init_module()
> > - *
> > - * Module load.  This is where it all starts.
> >   */
> 
> Just remove the whole comment.  We can see the function name just by
> reading down a few lines so the comment doesn't add any information.
> 
> >  static int dgap_init_module(void)
> >  {
> 
> Also the comment is out of date.  The function name has changed.
> 
> regards,
> dan carpenter
> 

Dan,I have sent v2 of this patchset.Sorry I forgot to CC you and Sudip.

Regards
Hari Prasath
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux