Re: [PATCH] staging: wilc1000: fix build warning related to time_after_eq macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 09, 2015 at 10:41:18AM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Tue, Jun 09, 2015 at 06:43:59AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> > 
> > This patch fixes a build warning related to the use of the time_after_eq
> > macro.Adding a typecast to the second argument suppresses the
> > warning.This warning was created by one my previous patch.
> > 
> > Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> > ---
> >  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > index 0db7f3d..0441d7b 100644
> > --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> > @@ -2252,7 +2252,7 @@ void WILC_WFI_p2p_rx (struct net_device *dev, uint8_t *buff, uint32_t size)
> >  		if (ieee80211_is_action(buff[FRAME_TYPE_ID])) {
> >  			PRINT_D(GENERIC_DBG, "Rx Action Frame Type: %x %x\n", buff[ACTION_SUBTYPE_ID], buff[P2P_PUB_ACTION_SUBTYPE]);
> > -			if (priv->bCfgScanning == WILC_TRUE && time_after_eq(jiffies, pstrWFIDrv->u64P2p_MgmtTimeout)) {
> > +			if (priv->bCfgScanning == WILC_TRUE && time_after_eq(jiffies, (unsigned long)pstrWFIDrv->u64P2p_MgmtTimeout)) {
> >  				PRINT_D(GENERIC_DBG, "Receiving action frames from wrong channels\n");
> >  				return;
> >  			}
> 
> This patch is corrupted and can not be applied :(
> 
> Please fix up and resend.
> 
> thanks,
> 
> greg k-h

sorry about that Greg.I will check that and send a v2.

Thanks & Regards
Hari Prasath
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux