Re: [PATCH] staging: dgap: do cleanup on module exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 09, 2015 at 09:27:22AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> 
> Cleanup the device entry,device class & unregister the character device
> in the module exit.All this cleanup is done already in the dgap_stop()
> function.We need to call this in the cleanup module.
No. this is wrong. The same thing what dgap_stop() does is being done in
dgap_remove_one() which is the remove callback. So your patch is trying
to destroy and unregister something which does not exist at the time dgap_stop()
will be called.

regards
sudip
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux