This whole patchset looks find to me. Some tips for the future. On Wed, Jun 03, 2015 at 04:43:20PM -0400, James Simmons wrote: > From: John L. Hammond <john.hammond@xxxxxxxxx> > > In lnet/lnet/ and lnet/selftest/ assume a kernel build (assume that > __KERNEL__ is defined). Remove some common code only needed for user > space LNet. > > - recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, > - sizeof(lnet_me_t)); > + recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, 0, 0); When I'm reviewing "delete code" patches, I pretty much focus on the plus lines like this one. Obviously, I can figure out why we changed the parameters to zero but it saves me time if it's spelled out in the changelog. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
