On Thu, 2015-06-04 at 19:04 +0530, Sudip Mukherjee wrote: > str was 16 bytes but was mentioned as 128 in snprintf. > again msg is 128 bytes but not sufficient to hold the complete debug > message of register values. > Now removed the use of str, msg and print the register values from the > loop. [] > v2: removed the use of msg and str. It's nice to cc the people that give you suggestions when you send a new version of a patch. > diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c [] > @@ -1067,8 +1067,6 @@ static int fbtft_init_display_dt(struct fbtft_par *par) > const __be32 *p; > u32 val; > int buf[64], i, j; [] > par->fbtftops.write_register(par, i, > buf[0], buf[1], buf[2], buf[3], It seems there are only 2 callers of (*write_register)() and the arguments are always an in-order array int[64] Maybe it'd be nicer to change the prototypes of the write_register functions to take a const int * instead of pushing 64 ints on the stack. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
