On Wed, 2015-06-03 at 17:12 +0000, Simmons, James A. wrote: > >On Wed, 2015-06-03 at 10:32 -0400, James Simmons wrote: > >> Handle all the style issues reported by checkpatch.pl. > >> Remove general white spaces, spaces in function calls, > >> etc. > >[] > >> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) > >> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { > >> toobig = 1; > >> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); > >> - CWARN("Too many interfaces: only enumerating first %d\n", > >> - nalloc); > >> + CWARN("Too many interfaces: only enumerating " > >> + "first %d\n", nalloc); > > > >Please don't split single strings into multiple parts. > > > >For a patch like this it'd be nice to specify that both > >"git diff -w" and scripts/objdiff shows no differences. > > > >Unless it does... > > Two patches have mistakes. Should I send a new series or do a in-reply instead. Most of the time, it's better to send a new series. If any of the unmodified patches are very large, like 100KB+, then it can be better to send individually updated patches. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel