>>On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote: >> Thanks for reviewing. >> >> The 2 struct members were not marked as __user, which this patch does >> here. This was causing warnings with copy from/to user (see commit >> description). This patch also propagates the annotation to the couple >> of functions that are using those members. > >Lustre's structures are a total mess of kernel and user pointers and >trying to properly mark them as which they are supposed to be at what >point in time is a very difficult task. People keep trying and get it >wrong, so I suggest just leaving this alone until the developers unwind >the structure mess as that will be necessary for this code to get merged >into the main part of the kernel. Greg is right. The earlier patch set I sent out for the LNet headers address this issue for the LNet layer. I also having patches coming that fix libcfs ioctl handling as well. I see Shuey's patches made it in first so I'm going to have to rebase. I will send out the new patch sets later today. This will be v3 of the patch set. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
