On Tue, Jun 02, 2015 at 12:01:14PM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote: > > On Tue, Jun 02, 2015 at 11:37:11AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > > >From : Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > > > > > > remove unwanted assignment to ih->check here as it will be > > > overwritten.Its not used in the ip_fast_csum() function as well. > > > > This code is hard for me to follow. How do you know it's not used in > > ip_fast_csum()? > > > > regards, > > dan carpenter > > > > Dan,this function to calculate the checksum of a IP header is defined > in the kernel source at lib/checksum.c. Yes. I know that. > This particular member is not > used in the function. Because it treats the whole struct as a char buffer. > I referred other drivers under drivers/net.It seems > that this assignment is not required before calling the function > ip_fast_csum(). I was really hoping you were going to make this simpler for me to review this patch but this information is very vague. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
