On Sun, May 31, 2015 at 10:01:03PM -0700, Isaac Assegai wrote: > Insert Spaces after commas to rectify the > following checkpatch errors in sm750_help.h: > ERROR: space required after that ',' > > Signed-off-by: Isaac Assegai <isaac.a.travers@xxxxxxxxx> > --- > drivers/staging/sm750fb/sm750_help.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750_help.h b/drivers/staging/sm750fb/sm750_help.h > index e0128d2..3940359 100644 > --- a/drivers/staging/sm750fb/sm750_help.h > +++ b/drivers/staging/sm750fb/sm750_help.h > @@ -10,11 +10,11 @@ > > #define RAW_MASK(f) (0xFFFFFFFF >> (32 - _COUNT(f))) > #define GET_MASK(f) (RAW_MASK(f) << _LSB(f)) > -#define GET_FIELD(d,f) (((d) >> _LSB(f)) & RAW_MASK(f)) > -#define TEST_FIELD(d,f,v) (GET_FIELD(d,f) == f ## _ ## v) > -#define SET_FIELD(d,f,v) (((d) & ~GET_MASK(f)) | \ > +#define GET_FIELD(d, f) (((d) >> _LSB(f)) & RAW_MASK(f)) > +#define TEST_FIELD(d, f, v) (GET_FIELD(d,f) == f ## _ ## v) ^^^ i guess you missed this one. regards sudip _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
