On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
The above line should not be here and it will appear as long as the
email client is not configured correctly. Just take a step back and
fix it as this is something that you do once and then it remains
*correct* forever.
The trick is to match the git user with the email user and you can
test it by sending the patches to yourself before they are posted
to the list.
Thanks and hope this helps.
- konrad
> This patch deletes all references to 'flipbuf'.Memory is allocated and
> freed but never used anywhere in the driver.Also deleted an ununsed
> Macro defined in the header file.
>
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 9 ---------
> drivers/staging/dgnc/dgnc_driver.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index 805dc61..7546aff 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -355,7 +355,6 @@ static void dgnc_cleanup_board(struct dgnc_board *brd)
> }
> }
>
> - kfree(brd->flipbuf);
>
> dgnc_Board[brd->boardnum] = NULL;
>
> @@ -581,14 +580,6 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
> brd->msgbuf_head = NULL;
> spin_unlock_irqrestore(&dgnc_global_lock, flags);
>
> - /*
> - * allocate flip buffer for board.
> - *
> - * Okay to malloc with GFP_KERNEL, we are not at interrupt
> - * context, and there are no locks held.
> - */
> - brd->flipbuf = kzalloc(MYFLIPLEN, GFP_KERNEL);
> -
> wake_up_interruptible(&brd->state_wait);
>
> return 0;
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index f77fed5..de9e71c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -288,7 +288,6 @@ struct un_t {
> #define CH_TX_FIFO_LWM 0x0800 /* TX Fifo is below Low Water */
> #define CH_BREAK_SENDING 0x1000 /* Break is being sent */
> #define CH_LOOPBACK 0x2000 /* Channel is in lookback mode */
> -#define CH_FLIPBUF_IN_USE 0x4000 /* Channel's flipbuf is in use */
> #define CH_BAUD0 0x08000 /* Used for checking B0 transitions */
> #define CH_FORCED_STOP 0x20000 /* Output is forcibly stopped */
> #define CH_FORCED_STOPI 0x40000 /* Input is forcibly stopped */
> --
> 1.9.1
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
