On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
>
> Remove braces around else clause with single line
>
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx>
> ---
> drivers/staging/xgifb/vb_init.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
> index 2b233af..8deab76 100644
> --- a/drivers/staging/xgifb/vb_init.c
> +++ b/drivers/staging/xgifb/vb_init.c
> @@ -484,9 +484,9 @@ static void XGINew_SetDRAMDefaultRegister340(
> if (HwDeviceExtension->jChipType == XG27)
> xgifb_reg_set(P3c4, 0x17, 0x02); /* SR17 DDRII */
>
> - } else {
> + } else
> xgifb_reg_set(P3c4, 0x17, 0x00); /* SR17 DDR */
> - }
If any of the branches in the conditional statement is long enough to
use braces you cannot do this. The 'else' should have braces around it.
See in https://www.kernel.org/doc/Documentation/CodingStyle, Chapter 3.
- konrad
> +
> xgifb_reg_set(P3c4, 0x1A, 0x87); /* SR1A */
>
> temp = XGINew_GetXG20DRAMType(HwDeviceExtension, pVBInfo);
> @@ -972,9 +972,8 @@ static void XGINew_ChkSenseStatus(struct vb_device_info *pVBInfo)
> CR3CData = xgifb_reg_get(pVBInfo->P3d4, 0x3c);
> if (!(CR3CData & DisplayDeviceFromCMOS))
> tempcx = 0x1FF0;
> - } else {
> + } else
> tempcx = 0x1FF0;
> - }
>
> tempbx &= tempcx;
> xgifb_reg_set(pVBInfo->P3d4, 0x3d, (tempbx & 0x00FF));
> @@ -1129,10 +1128,9 @@ static void XGINew_GetXG27Sense(struct vb_device_info *pVBInfo)
> /* LVDS setting */
> xgifb_reg_and_or(pVBInfo->P3d4, 0x38, ~0xE0, 0xC0);
> xgifb_reg_set(pVBInfo->P3d4, 0x30, 0x21);
> - } else {
> + } else
> /* TMDS/DVO setting */
> xgifb_reg_and_or(pVBInfo->P3d4, 0x38, ~0xE0, 0xA0);
> - }
> xgifb_reg_or(pVBInfo->P3d4, 0x32, LCDSense);
>
> }
> --
> 1.9.1
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
