On Mon, Jun 01, 2015 at 01:12:18PM +0300, Dan Carpenter wrote: > On Mon, Jun 01, 2015 at 09:41:52AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > From: Hari Prasath Gujulan Elango <hgujulan@xxxxxxxxxxx> > > > > This trivial patch removes temporary variable to check return value of > > a function and checks return value directly. > > > > This isn't an improvement. We want to adopt normal kernel error codes > every where but this code moves us backward. > > regards, > dan carpenter > Dan yes this doesn't make any improvement.The 'retval' variable was used only at this place so removed it. This 'retval' value is not returned as well in this function. regards Hari Prasath _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
