Re: [PATCH v5 00/34] staging: rtl8192e: Fix more checkpatch.pl warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2015-05-31 at 20:19 +0200, Mateusz Kulikowski wrote:
> Updated series of patches for rtl8192.
[]
>  31 files changed, 1260 insertions(+), 2011 deletions(-)

Nice diffstat

btw:

If you have to resubmit this, please try to remove
the unnecessary periods after logging statements.

Things like:

-                               RT_TRACE(COMP_ERR,
-                                        "PHY_SetRF8256Bandwidth(): unknown hardware version\n");
+                               netdev_warn(dev, "%s(): Unknown HW version.\n",
+                                           __func__);

aren't sentences and don't need punctuation.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux