Re: [PATCH] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 31, 2015 at 10:45:27AM +0900, Greg KH wrote:
> On Tue, May 26, 2015 at 06:47:14PM -0300, Gaston Gonzalez wrote:
> > Fix the following sparse warnings:
> > 
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types)
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:    expected restricted __le16 [usertype] frame_ctl
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:    got int
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: warning: invalid assignment: |=
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50:    left side has type restricted __le16
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50:    right side has type int
> > 
> > 
> > Signed-off-by: Gaston Gonzalez <gascoar@xxxxxxxxx>
> > ---
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > index d2e8b12..0477ba1 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > @@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
> >  	auth = (struct ieee80211_authentication *)
> >  		skb_put(skb, sizeof(struct ieee80211_authentication));
> > 
> > -	auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> > -	if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> > +	auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
> > +	if (challengelen)
> > +		auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);
> > 
> >  	auth->header.duration_id = 0x013a; //FIXME
> > 
> 
> This patch doesn't apply properly for some reason, can you fix it up and
> resend?
> 
> thanks,
> 
> greg k-h
Hi Greg,

I couldn't find the problem with this patch. Just in case I redo the patch
against the updated staging-testing and resent it. To test it I did:

 - run checkpatch
 - git apply --check
 - email it to myself and then 'git am' from mutt 
 - git log

I've just sent the patch. Please let me know if I missed something.

Thanks,

Gaston 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux