Re: [PATCH] Patch to integrate RapidDisk and RapidCache RAM Drive / Caching modules into staging subsystem.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 30, 2015 at 06:46:26PM -0500, Petros Koutoupis wrote:
> Attached is a patch for two modules: RapidDisk & RapidCache. RapidDisk is a
> Linux RAM drive module which allows the user to dynamically create, remove, and
> resize RAM-based block devices. RapidDisk is designed to work with both
> volatile and non-volatile memory. In the case of volatile memory, memory is
> allocated only when needed. The RapidCache module in turn utilizes a RapidDisk
> volume as a FIFO Write-Through caching node to a slower block device.
> 
> This patch is currently against the linux-next tree (next-20150529).

This line doesn't need to be in the changelog area.

> 
> When the patch is applied, a new option will appear in the drivers/staging
> menuconfig "RapidDisk Enhanced Linux RAM disk solution". Enabling this sets the
> variable CONFIG_RXDSK.

Neither does this paragraph.

> diffstat for this patch is:
>  Kconfig                           |    2 
>  Makefile                          |    1 
>  rapiddisk/Documentation/rxdsk.txt |   67 ++
>  rapiddisk/Kconfig                 |   10 
>  rapiddisk/Makefile                |    2 
>  rapiddisk/rxcache.c               | 1142
> ++++++++++++++++++++++++++++++++++++++
>  rapiddisk/rxcommon.h              |   22 
>  rapiddisk/rxdsk.c                 |  773 +++++++++++++++++++++++++
>  8 files changed, 2019 insertions(+)

This doesn't need to be here either, it should be below the --- line.


> 
> To apply this patch, in the root of the kernel tree use:
> patch -p1 <rapiddisk.patch

That's not how I apply patches :)

Again, not needed.

> 
> Please share feedback, questions, or concerns.
> 
> Regards,
> 
> Petros Koutoupis
> www.rapiddisk.org
> 
> Signed-off-by: Petros Koutoupis <petros@xxxxxxxxxxxxxxxxxxx>


This is what we need, but not the signature or other bits in the
changelog area.  Look at how other patches are submitted, that should
give you an idea of how to format things.

I need a TODO file for staging drivers, describing what needs to be done
to it to get it moved out of staging, and who to cc: on patches.  Or you
can add a MAINTAINERS entry for the cc: portion, that's usually better.

can you fix this all up and resend it so that I can apply it?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux