Re: [PATCH 14/16] staging: wilc1000: remove semaphore wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
> The various semaphore functions all directly translate into
> sema_init(), down() and up(), so we can just remove the API.
> 
> This is a mostly automated conversion using simple sed scripts,
> plus some manual changes to account for down() returning no
> error.
> 
> As a positive side-effect, down() no longer hangs after
> receiving a signal, as the original code did by looping around
> down_interruptible.
> 
> The semaphores still need to be turned into mutexes as a
> follow-up step.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/staging/wilc1000/coreconfigurator.c       |  29 +---
>  drivers/staging/wilc1000/fifo_buffer.c            | 108 +++++++-------
>  drivers/staging/wilc1000/fifo_buffer.h            |   2 +-
>  drivers/staging/wilc1000/host_interface.c         | 171 +++++++++-------------
>  drivers/staging/wilc1000/host_interface.h         |  16 +-
>  drivers/staging/wilc1000/wilc_msgqueue.c          |  32 ++--
>  drivers/staging/wilc1000/wilc_oswrapper.h         |   3 -
>  drivers/staging/wilc1000/wilc_platform.h          |   4 +-
>  drivers/staging/wilc1000/wilc_semaphore.c         |  56 -------
>  drivers/staging/wilc1000/wilc_semaphore.h         |  99 -------------
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  35 ++---
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h     |   4 +-
>  12 files changed, 160 insertions(+), 399 deletions(-)
>  delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.c
>  delete mode 100644 drivers/staging/wilc1000/wilc_semaphore.h
wilc_semaphore still remains in the Makefile.

regards
sudip
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux