On Thu, May 28, 2015 at 09:50:23PM +0300, Dan Carpenter wrote: > On Thu, May 28, 2015 at 09:39:14AM -0700, insop.song@xxxxxxxxxxxxx wrote: > > On Thu, May 28, 2015 at 01:08:36PM +0300, Dan Carpenter wrote: > > > On Thu, May 28, 2015 at 09:38:23AM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > > > > remove redundant code in this function by introducing a new retval > > > > variable. > > > > > > > > Signed-off-by: Gujulan Elango Hari Prasath <hgujulan@xxxxxxxxxxx> > > > > > > No the original code is quite bad but this patch makes it worse. > > > > Please elaborate what was 'quite bad' in the original code? > > GW-BASIC labels. what do you mean? > return -1 instead of proper error codes. Okay, > poorly thought out error messages. which one are you exactly refering? I went through all error messages, but cannot find which one(s) you exactly mean. > The error handling of gs_release_image() was silly. I would say, ""The error handling of gs_release_image() was "unnecessary""" instead. So your feedback is mostly on error code and error messages Thank you for your feedback. Regards, ISS _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
