Local functions not used in other modules should be static, not extern. (patch checked against linux-next and staging) Signed-off-by: Xavier Roche <roche@xxxxxxxxxxx> --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c index 83683e9..3237ee73 100644 --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c @@ -82,12 +82,12 @@ #define STATE_DONE_PROV 0x06 #define STATE_DONE_FILE 0x07 -u16 get_handshake(struct net_device *dev, u16 expected_value); -void put_handshake(struct net_device *dev, u16 handshake_value); -u16 get_request_type(struct net_device *dev); -long get_request_value(struct net_device *dev); -void put_request_value(struct net_device *dev, long lvalue); -u16 hdr_checksum(struct pseudo_hdr *pHdr); +static u16 get_handshake(struct net_device *dev, u16 expected_value); +static void put_handshake(struct net_device *dev, u16 handshake_value); +static u16 get_request_type(struct net_device *dev); +static long get_request_value(struct net_device *dev); +static void put_request_value(struct net_device *dev, long lvalue); +static u16 hdr_checksum(struct pseudo_hdr *pHdr); struct dsp_file_hdr { u32 version_id; /* Version ID of this image format. */ @@ -146,7 +146,7 @@ void card_bootload(struct net_device *dev) spin_unlock_irqrestore(&info->dpram_lock, flags); } -u16 get_handshake(struct net_device *dev, u16 expected_value) +static u16 get_handshake(struct net_device *dev, u16 expected_value) { struct ft1000_info *info = netdev_priv(dev); u16 handshake; @@ -180,7 +180,7 @@ u16 get_handshake(struct net_device *dev, u16 expected_value) } -void put_handshake(struct net_device *dev, u16 handshake_value) +static void put_handshake(struct net_device *dev, u16 handshake_value) { struct ft1000_info *info = netdev_priv(dev); u32 tempx; @@ -196,7 +196,7 @@ void put_handshake(struct net_device *dev, u16 handshake_value) } } -u16 get_request_type(struct net_device *dev) +static u16 get_request_type(struct net_device *dev) { struct ft1000_info *info = netdev_priv(dev); u16 request_type; @@ -215,7 +215,7 @@ u16 get_request_type(struct net_device *dev) } -long get_request_value(struct net_device *dev) +static long get_request_value(struct net_device *dev) { struct ft1000_info *info = netdev_priv(dev); long value; @@ -244,7 +244,7 @@ long get_request_value(struct net_device *dev) } -void put_request_value(struct net_device *dev, long lvalue) +static void put_request_value(struct net_device *dev, long lvalue) { struct ft1000_info *info = netdev_priv(dev); u16 size; @@ -271,7 +271,7 @@ void put_request_value(struct net_device *dev, long lvalue) } -u16 hdr_checksum(struct pseudo_hdr *pHdr) +static u16 hdr_checksum(struct pseudo_hdr *pHdr) { u16 *usPtr = (u16 *)pHdr; u16 chksum; -- 1.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel