On Tue, May 26, 2015 at 04:34:55PM +0200, Jason A. Donenfeld wrote: > On Tue, May 26, 2015 at 4:06 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > You sure do like wrapping to a high value and testing the result for > > wrapping instead of validating before doing the subtraction... > > I do indeed. It seems like asking "did it overflow?" is more > straight-forward and easier to read than trying to come up with the > necessary conditions to check for "will it overflow?". Personal > preference, I guess. It's really not simpler to understand though. Also future static checkers will complain that subtracting from a user variable and you might underflow. I am updating my static checker to detect these. Also overflow and truncate might not be the right fix, maybe it's better to just drop the invalid request (patch 2/4). What's going on with the mailing list? We seem to be losing people from the CC. I deliberately added Shigekatsu Tateno, and it says he was on the CC in my outbox but now he isn't. Maybe we should just delete these ozwpan drivers entirely... They were merged when Ozmodevices was its own company and I don't think anyone is working on them any more. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
