On Wed, May 27, 2015 at 8:29 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Wed, May 27, 2015 at 08:24:18PM +0300, Vladimirs Ambrosovs wrote: >> On Wed, May 27, 2015 at 09:21:28AM +0300, Daniel Baluta wrote: >> > Hi, >> > >> > On Wed, May 27, 2015 at 1:19 AM, Vladimirs Ambrosovs >> > <rodriguez.twister@xxxxxxxxx> wrote: >> > > This patch fixes the init function for the iio_simple_dummy driver. >> > > The main issues were absence of kfree for the allocated array, and no >> > > devices being removed in case the probe function fails, running in a loop. >> > > >> > > The iio_dummy_remove function was also changed: >> > > * The return value was changed to void >> > > * The check for return value of iio_simple_dummy_events_unregister() >> > > The reason for this changes is that, as per implementation, >> > > events_unregister function always returns 0, so we are safe not to check >> > > return value. As a result the return value for iio_dummy_remove function >> > > becomes useless as well, hence return value type change. >> > >> > While at it I think we can also make >> > iio_simple_dummy_events_unregister return type void. >> > Nice to see that people pay attention to the dummy module :). >> > >> > As part of Outreachy program, Cristina (CC'ed) will work on making the >> > IIO dummy driver >> > more useful with the final goal of moving it out of staging. >> > >> > http://kernelnewbies.org/OutreachyIntro >> > >> > >> Thanks, that's a good point. Should I re-submit the patch, or better >> reject the changes, and leave it to Cristina to address in scope of >> Outreachy project? > > No no. Please resend the patches. Agree. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
