Re: [PATCH] staging: sm750fb: replace kzalloc with devm_kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 27, 2015 at 07:53:02AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
> > On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
> > > On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > > > On Tue, May 26, 2015 at 10:04:44AM +0000, Gujulan Elango, Hari Prasath (H.) wrote:
> > > > > replace kzalloc with devm_kzalloc thereby removing the corresponding
> > > > > kfree.
> > > > your patch is corrupt and can not be applied.
> > > > But even then, can this be called as code improvement?
> > > 
> > > It applies fine here.  This seems like a nice patch.
> > But my checkpatch is still giving errors about corrupt patch :(
> 
> Before I send any patch,I ensure to run checkpatch.pl on the patch and
> this patch is no exception. It didn't give me any errors or
> warnings.Running checkpatch.pl on the modified file does generate some
> warnings and errors but none of them related to the changes I did.
tested again.
strange behaviour.
if i send your patch to checkpatch from mutt via pipe I am getting these
errors but if i save your patch to a file and then apply checkpatch to
that file there is no error. This is the first time I am seeing this.

Dan, any idea why?

regards
sudip

> 
> warm regards
> Hari Prasath
> 
> > 
> > regards
> > sudip
> > 
> > 
> > > 
> > > regards,
> > > dan carpenter
> > > 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux