RE: [PATCH] staging: comedi: comedi_8254.h: make self-reliant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, May 22, 2015 10:33 AM, Ian Abbott wrote:
> The Comedi "comedi_8254.h" header file is included by various Comedi
> drivers with timer/counters based on the 8254 chip.  The drivers do not
> compile cleanly if this header file is included first.  It uses pointers
> to the `struct comedi_device`, `struct comedi_subdevice`, and `struct
> comedi_insn` structures in various function prototypes, so declare those
> as incomplete types.  It use the `bool` type, so include
> <linux/types.h>.  It also uses the `__iomem` tag, but that seems to be
> taken care of indirectly by including <linux/types.h>.
>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux