Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/05/15 13:35, Dan Carpenter wrote:
> This is also wrong then.
>
> regards,
> dan carpenter
Hi Dan,

Yes, you are right. It is the next sparse warning in line for that file.
Including the fix for that, the patch would be as showed below.

There are similar endianness warnings for other variables in that file,
like the FIXME in last line of the patch. But keeping in mind the rule
'one thing per patch' I guess this should be fixed in other patche/s, right?

Regards,

Gaston

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e8b12..0477ba1 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -660,2 +660,2 @@ inline struct sk_buff
*ieee80211_authentication_req(struct ieee80211_network *be
     auth = (struct ieee80211_authentication *)
         skb_put(skb, sizeof(struct ieee80211_authentication));

-    auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
-    if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
+    auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
+    if (challengelen)
+        auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);

     auth->header.duration_id = 0x013a; //FIXME

--
2.1.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux