On Wed, May 20, 2015 at 10:51:34PM +0000, Dilger, Andreas wrote:
> On 2015/05/20, 1:42 PM, "Dan Carpenter" <dan.carpenter@xxxxxxxxxx> wrote:
>
> >In Smatch, it the equivalent warning is turned off by default because
> >there are too many false positives, but you can enable it with the
> >--spammy flag.
> >
> >kchecker --spammy drivers/staging/lustre/lustre/ptlrpc/nrs.c
> >
> >drivers/staging/lustre/lustre/ptlrpc/nrs.c:512 nrs_resource_put_safe()
> >warn: 'spin_lock:&nrs->nrs_lock' is sometimes locked here and sometimes
> >unlocked.
>
> Would this be happier with something like:
>
> for (i = 0; i < NRS_RES_MAX; i++) {
> if (pols[i] == NULL)
> continue;
>
>
> if (nrs == NULL) {
> nrs = pols[i]->pol_nrs;
> if (likely(nrs != NULL)) /* make sparse happy */
> spin_lock(&nrs->nrs_lock);
> }
> nrs_policy_put_locked(pols[i]);
> }
>
> if (nrs != NULL)
> spin_unlock(&nrs->nrs_lock);
>
> so that the "if" conditions are the same? The code definitely doesn't
> have a bug, because the lock is only locked once when nrs is first set,
> and only unlocked if it is set. Or is there a comment to put there that
> will quiet the static checker?
Forget about Sparse, it's good at some things and it's fast but it has
crappy flow analysis compared to Smatch.
Adding that check does actually silence the warning in Smatch but it's
a bad idea. Smatch is supposed to know that "nrs" is non-NULL because
of the dereference on the next line. I think this is a recent
regression. I'll look into it.
Smatch doesn't have a way to silence false positives. It's still
developing, so many of these false positives can be solved by improving
the flow analysis.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
