On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> >
> > Tested-by: Jean Delvare <jdelvare@xxxxxxx>
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > ---
>
> In general:
>
> Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>
> > static struct parport_driver i2c_parport_driver = {
> > - .name = "i2c-parport",
> > - .attach = i2c_parport_attach,
> > - .detach = i2c_parport_detach,
> > + .name = "i2c-parport",
> > + .match_port = i2c_parport_attach,
> > + .detach = i2c_parport_detach,
> > + .devmodel = true,
>
> Minor nit: I prefer to not use tabs but a single space after the struct
> member names. Less hazzle in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
I will wait today for some more review and send v2 tomorrow with this
chanage.
regards
sudip
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
