On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote: > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > > Merge two pr_debug lines with literal strings splitted across several lines > > into one single line, simplifying prism2_wep_init error check code. > > Openning braces should never be in a new line, move them to the end of > > the previous line. > > Removed two useless lines at ieee80211_wep_null. > > > > When Joe said "Some will say this is doing too many things in a single > patch." he meant Greg. Break this up into multiple patches. Especially > now that you've added even more stuff to it. > > regards, > dan carpenter Sorry Joe, English is not my mother tongue and I misunderstand your comment, I thought "Some will say this is doing too many things in a single patch" did meant "You are on the limit, but it is ok to send it in one patch" but I see it really means "please, rewrite this whole crap into several patches" :-) So I guess an v3 patch should be a chain of several patches, I think a sensible approach would be three patches 1/3 => rewrite of the error check code 2/3 => remove of the two useless lines at ieee80211_wep_null. 3/3 => move openning braces and correct the indentation of the #include What do you think about it? regards, Pedro _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
