Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote:
> This patch fixes to use ether_addr_copy() instead of memcpy()
> 
> Encounter this by applying checkpatch.pl against this file:
>   WARNING: Prefer ether_addr_copy() over memcpy()
>   if the Ethernet addresses are __aligned(2)
> 
> Signed-off-by: Jagan Teki <jteki@xxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Florian Schilhabel <florian.c.schilhabel@xxxxxxxxxxxxxx>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

You need to prove that the addresses are aligned, please do so in the
changelog entry.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux