On Fri, May 15, 2015 at 12:09:42PM +0000, Gujulan Elango, Hari Prasath (H.) wrote: > Use a temporary value to hold the SD lock status thereby making the code > readable.This also fixes a coding style violation with the braces around > the if block. > This isn't more readable than the original code. The right fix is to get rid if #ifdefs from the .c files. Figure out when SUPPORT_SD_LOCK is defined and when it's not. Add a #define LOCK_STATUS 0x7D or 0x7F to the right places in the header files. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel