On Sat, May 09, 2015 at 12:06:32PM +0300, Dan Carpenter wrote: > On Sat, May 09, 2015 at 12:05:19PM +0300, Dan Carpenter wrote: > > On Sat, May 09, 2015 at 12:01:54PM +0300, Dan Carpenter wrote: > > > On Tue, May 05, 2015 at 06:37:42PM -0400, Benjamin Romer wrote: > > > > From: Don Zickus <dzickus@xxxxxxxxxx> > > > > > > > > cleanup: > > > > - bus_epilog(bus_no, CONTROLVM_BUS_CREATE, &inmsg->hdr, > > > > + bus_epilog(bus_info, CONTROLVM_BUS_CREATE, &inmsg->hdr, > > > > rc, inmsg->hdr.flags.response_expected == 1); > > > > } > > > > > > On some error paths "bus_info" is NULL. One err bug. > > > > Ugh... Basically ever place that calls bus_epilog() is buggy. > > Or device_epilog(). Agree 100%. :-) I have a patch in Ben's queue to re-work the failure paths. I have to rework my patches anyway to address Greg's request. I will see if I can get Ben to include those patches too to address this when we repost. Cheers, Don _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
