> -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Sunday, May 10, 2015 2:51 PM > To: KY Srinivasan > Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; > jasowang@xxxxxxxxxx > Subject: Re: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag > to optimize signaling the host > > From: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> > Date: Wed, 6 May 2015 15:29:05 -0700 > > > - ret = vmbus_sendpacket_pagebuffer(out_channel, > > - pgbuf, > > - packet->page_buf_cnt, > > - &nvmsg, > > - sizeof(struct > nvsp_message), > > - req_id); > > + ret = vmbus_sendpacket_pagebuffer_ctl(out_channel, > > + pgbuf, > > + packet->page_buf_cnt, > > + &nvmsg, > > + sizeof(struct > > + nvsp_message), > > + req_id, > > + vmbus_flags, > > + !packet->xmit_more); > > } else { > > - ret = vmbus_sendpacket( > > + ret = vmbus_sendpacket_ctl( > > out_channel, &nvmsg, > > sizeof(struct nvsp_message), > > req_id, > > VM_PKT_DATA_INBAND, > > - > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); > > + vmbus_flags, !packet->xmit_more); > > Just as you did for the vmbus_sendpacket_pagebuffer_ctl() call above, > you'll need to reindent the arguments for the vmbus_sendpacket_ctl() > call since the openning parenthesis is now at a different column. Done. Regards, K. Y > > Thanks. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
